Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.1: com.intellij.diagnostic.PluginException: ActionUpdateThread.OLD_EDT is deprecated and going to be removed soon #5993

Closed
tpasternak opened this issue Jan 29, 2024 · 2 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin type: bug

Comments

@tpasternak
Copy link
Collaborator

tpasternak commented Jan 29, 2024

Description of the bug:

When using the plugin, this exception is thrown frequently (not only for BlazeMenuGroup)

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.google.idea.blaze.base.actions.BlazeMenuGroup' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.google.idea.bazel.ijwb]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:198)

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which Intellij IDE are you using? Please provide the specific version.

IntelliJ 2024.1

No response

What programming languages and tools are you using? Please provide specific versions.

No response

What Bazel plugin version are you using?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@tpasternak tpasternak added type: bug awaiting-maintainer Awaiting review from Bazel team on issues labels Jan 29, 2024
@sgowroji sgowroji added the product: IntelliJ IntelliJ plugin label Jan 29, 2024
@tpasternak
Copy link
Collaborator Author

cc @ujohnny @agluszak I'm wondering if we should go through all actions one-by-one, or just safely default do EDT as it used to be before. We haven't experienced any update-related freezes but still we might occupy some significant parts of edt which could be used by others

@ujohnny
Copy link
Collaborator

ujohnny commented Feb 29, 2024

fixed by #6101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues product: IntelliJ IntelliJ plugin type: bug
Projects
None yet
Development

No branches or pull requests

7 participants