Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement upload/download cancellation #211

Open
ola-rozenfeld opened this issue Oct 15, 2020 · 0 comments
Open

implement upload/download cancellation #211

ola-rozenfeld opened this issue Oct 15, 2020 · 0 comments
Assignees
@ola-rozenfeld
Labels
category: performance performance improvement lang: go status: fixed type: feature request

Comments

@ola-rozenfeld
Copy link
Contributor

When the uploads/downloads are unified, we don't really support cancellations -- the context may be canceled and the caller immediately returns, but the upload/download still happens in the background, consuming resources.
Ideally, for large (non-batched) reads and writes, if ALL clients interested in the digest are canceled, then we should terminate the RPC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ola-rozenfeld ola-rozenfeld

Labels
category: performance performance improvement lang: go status: fixed type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ola-rozenfeld