Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 2.x usage on macOS #1036

Closed
fffonion opened this issue Apr 11, 2023 · 0 comments · Fixed by #1037
Closed

python 2.x usage on macOS #1036

fffonion opened this issue Apr 11, 2023 · 0 comments · Fixed by #1037

Comments

@fffonion
Copy link
Contributor

Hi all, I noticed python 2.x support is dropped per #1005.

However, the python 3.x installation only produce python3 under normal PATH.

In some macOS commands helpers, we use python instead of python3 like (

rules_foreign_cc/foreign_cc/private/framework/toolchains/macos_commands.bzl

Line 264 in d33d862

target="$(python -c "import os; print(os.path.realpath('{file}'))")"
) and it causes error.

Should these commands be changed to python3 instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use python3 instead of python2 in macos commands fffonion/rules_foreign_cc
1 participant
@fffonion