-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the docs back! #690
Comments
Sorry the change to the docs upset you! But I thought all the docs and previously links were still valid and active. Can you elaborate more on how this commit impacted you? |
I think the diff really speaks for itself here honestly, but sure. As you are aware, it's a common practice to keep the What's even more curious is that even the high-level description of the ruleset's features has been removed from the README in favor of the generated content hosted externally and buried under a link which is both easy to miss and hosted on an unfamiliar site with unknown uptime/availability, not to mention operated by a for-profit third-party. Not a good look. As I said previously, I'm all for using the tooling to generate docs here and generally supportive of anything that makes any of the rulesets easier to discover and work with, and clearly there are improvements to be made in this area across most rulesets, but this is pretty clearly worsening the UX rather than improving it in ways that again are pretty obvious, but to flag some quickly:
A summary of the issues that affect all would-be users, especially those who are newer to bazel (probably the majority of the users of this ruleset hoping to build legacy/non-bazel cc due to the fact they're in the process of evaluating/adopting): 1: Any divergence from content inlined into the README is a downgrade on UX & SEO; at a minimum, description and installation should be restored, even if doc gen is in place |
In general, I'd have appreciated a less demanding tone. You'll find that all the WORKSPACE context can be found in index.md which is committed to the repo. The intent was to have users navigate to a site that would properly show the intended landing page as github renders I will restore the committed docs but in the future, I will be less responsive to changes that are demanded vs requested. It's a fair argument that https://docs.aspect.dev/ is a 3rd party site and a competitor to https://flare.build/ (it'd seem) and it'd be unfair to rely on one vs another. |
👍 I could have phrased the issue title a little better for sure, was trying to convey only urgency thanks for your responsiveness and the great work on the project |
I recently discovered that the documentation has been removed in favor of a third-party site in this commit.
While I applaud this as a clever SEO strategy on the part of the consultant, this is just a net negative for everyone else, and I'm frankly surprised to see this kind of change coming through to repos hosted under
bazelbuild
. I understand that this is no longer maintained by Google, but even still... 🤦I'm all for improving the docs for
bazelbuild
projects but this is clearly the wrong direction.Revert #652
The text was updated successfully, but these errors were encountered: