Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of FreeBSD SDK #1497

Merged
merged 1 commit into from May 11, 2018
Merged

Enable use of FreeBSD SDK #1497

merged 1 commit into from May 11, 2018

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented May 11, 2018

This allows a simple repo to be used on FreeBSD (amd64). I manually
tested the change on a toy project and bazel build/test both worked as I
expected them to work based upon what I've come to expect on Linux.

Signed-off-by: Robert Escriva robert@rescrv.net

This allows a simple repo to be used on FreeBSD (amd64).  I manually
tested the change on a toy project and bazel build/test both worked as I
expected them to work based upon what I've come to expect on Linux.

Signed-off-by: Robert Escriva <robert@rescrv.net>
Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding this! We don't have any FreeBSD CI systems, so we won't be able to test this regularly, but if it works for you, we're happy to have it on.

@jayconrod jayconrod merged commit 3b103d6 into bazelbuild:master May 11, 2018
@iphydf
Copy link

iphydf commented May 11, 2018

Nice, thanks, I'll be testing this regularly myself. Currently not with ci, but hopefully that'll change some time this year.

jayconrod pushed a commit that referenced this pull request Jun 12, 2018
This allows a simple repo to be used on FreeBSD (amd64).  I manually
tested the change on a toy project and bazel build/test both worked as I
expected them to work based upon what I've come to expect on Linux.

Signed-off-by: Robert Escriva <robert@rescrv.net>
jayconrod pushed a commit that referenced this pull request Jun 12, 2018
This allows a simple repo to be used on FreeBSD (amd64).  I manually
tested the change on a toy project and bazel build/test both worked as I
expected them to work based upon what I've come to expect on Linux.

Signed-off-by: Robert Escriva <robert@rescrv.net>
jayconrod pushed a commit that referenced this pull request Jun 12, 2018
This allows a simple repo to be used on FreeBSD (amd64).  I manually
tested the change on a toy project and bazel build/test both worked as I
expected them to work based upon what I've come to expect on Linux.

Signed-off-by: Robert Escriva <robert@rescrv.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants