Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD setup for examples #3318

Closed
chrislovecnm opened this issue Oct 13, 2022 · 3 comments
Closed

CI/CD setup for examples #3318

chrislovecnm opened this issue Oct 13, 2022 · 3 comments

Comments

@chrislovecnm
Copy link
Contributor

We are missing the CD/CI setup for the examples with MacOS. I figured out how to do it for ubuntu, but I do not know how to set this line:

rules_go/.bazelci/presubmit.yml

Line 28 in d517cd9

platform: ubuntu2004

For MacOSX
@chrislovecnm chrislovecnm mentioned this issue Oct 13, 2022
Merged
@fmeum
Copy link
Collaborator

fmeum commented Oct 13, 2022

The value should be macos: If platform isn't given explicitly, it defaults to the name of the job.

@chrislovecnm
Copy link
Contributor Author

@fmeum, can we get the first PR merged, and then I will loop back on this?

@chrislovecnm
Copy link
Contributor Author

Closing this as I fixed it in #3317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrislovecnm @fmeum