rules_go 0.40+ broke gopls resolving stdlib imports in VS code

[bluec0re]

What version of rules_go are you using?

Tested with 0.40.1 and 0.42

What version of gazelle are you using?

0.31.1 and 0.33

What version of Bazel are you using?

6.4.0

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

Linux amd64

Any other potentially useful information about your toolchain?

Tested with gopls 0.13.2 and 0.14.1.

Using these settings in VS code:

 "go.goroot": "${workspaceFolder}/bazel-${workspaceFolderBasename}/external/go_sdk/",
  "go.toolsEnvVars": {
    "GOPROXY": "off",
    "GOPACKAGESDRIVER": "${workspaceFolder}/scripts/gopackagesdriver.sh",
  },
  "gopls": {
    "build.directoryFilters": [
      "-bazel-bin",
      "-bazel-out",
      "-bazel-testlogs",
      "-bazel-${workspaceFolderBasename}"
    ],
    [...]
  },

and this gopackagesdriver.sh:

#!/bin/sh

bazel="$(command -v bazel || command -v bazelisk)"
# reset GOPROXY to default
unset GOPROXY

# don't fetch internal stuff
export GOPRIVATE="[...]*"

exec "${bazel}" run -- @io_bazel_rules_go//go/tools/gopackagesdriver "$@"

What did you do?

Updated rules_go from 0.39.1 to 0.42 (and then later backtracked the problem to 0.40)

What did you expect to see?

gopls is able to resolve stdlib imports in VS code as before.

What did you see instead?

A lot of import errors in the format of could not import $PKG (cannot find packge "$PKG" in GOROOT or GOPATH).

[JamyDev]

Could you provide the output of echo {} | ./scripts/gopackagesdriver.sh builtin and save it on gist.github.com?

[bluec0re]

I saved the output for 0.39.1 and 0.40.1 and also a diff between them.

To be able to generate the diff, it used echo {} | ./scripts/gopackagesdriver.sh builtin | jq '.Packages |= sort_by(.PkgPath)' | jq '.Roots |= sort' to create the files.

[bluec0re]

Interestingly, it shows no error for unsafe but the gopls logs report "no readable files" when using jump to definition:

[Error - 12:38:35 PM] Request textDocument/definition failed.
  Message: package "@io_bazel_rules_go//stdlib:unsafe" has no readable files
  Code: 0 

[JamyDev]

Do you know what gopls version you're running? the outputs you shared seem normal 🤔