Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating @maven//foo_bar on top of @maven//:foo_bar to share convention across Bazel's external repository rules #164

Closed
jin opened this issue Jun 5, 2019 · 3 comments

Comments

@jin
Copy link
Member

jin commented Jun 5, 2019

Context: #160 (comment)

@Globegitter
Copy link

Maybe it is also worth considering a backwards-incompatible way and just exposing @maven//foo_bar to not have yet another alias. WDYT?

Also do you think it might be worth adding something to the best practices section the bazel docs about how to fetch external repos and hot to expose them?

@jin
Copy link
Member Author

jin commented Jun 7, 2019

@Globegitter Yeah, it's possible that we can do that but I'm hesitant on changing the API across the ecosystem for a cosmetic reason.

cc @dslomov @laurentlb for any thoughts about external dep conventions

@jin
Copy link
Member Author

jin commented Jul 19, 2019

Closing this as we'll not be doing this unless there's more demand for a standardized naming style across different package management rulesets.

@jin jin closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants