Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for v1.9.0 contain incorrect url for http_archive #1065

Closed
srabraham opened this issue Nov 1, 2023 · 4 comments
Closed

Release notes for v1.9.0 contain incorrect url for http_archive #1065

srabraham opened this issue Nov 1, 2023 · 4 comments

Comments

@srabraham
Copy link

srabraham commented Nov 1, 2023

The release notes for release v1.9.0 contain this snippet

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_kotlin",
    sha256 = "5766f1e599acf551aa56f49dab9ab9108269b03c557496c54acaf41f98e2b8d6",
    strip_prefix = "rules_kotlin-1.9.0",
    url = "https://github.com/buildfoundation/rules_kotlin/releases/download/v1.9.0/rules_kotlin-v1.9.0.tar.gz",
)

but when I actually click on the above link or use it in a rule, I get a 404: https://github.com/buildfoundation/rules_kotlin/releases/download/v1.9.0/rules_kotlin-v1.9.0.tar.gz

is it supposed to reference the repo bazelbuild/rules_kotlin instead? This does work for me: https://github.com/bazelbuild/rules_kotlin/releases/download/v1.9.0/rules_kotlin-v1.9.0.tar.gz

@Bencodes
Copy link
Collaborator

Bencodes commented Nov 1, 2023

Thanks for catching this.

I updated the description to point at the correct URL.

@srabraham
Copy link
Author

Thanks for catching this.

I updated the description to point at the correct URL.

Thank you!

@th0masb
Copy link

th0masb commented Nov 5, 2023

Thanks for catching this.

I updated the description to point at the correct URL.

The release notes are still wrong. The archive at the updated download link has no "rules_kotlin-1.9.0" prefix to strip so bazel complains. Also

http_archive(
    name = "rules_kotlin",
    ...
)

seems to contradict

If you are referencing any targets under @com_github_jetbrains_kotlin//... in your build files you will need to replace them with @io_bazel_rules_kotlin//kotlin/compiler:...

Why have we switched the repository name from "io_bazel_rules_kotlin" to "rules_kotlin"?

@Bencodes
Copy link
Collaborator

Bencodes commented Nov 6, 2023

@th0masb

The release notes are still wrong.

Argh thanks for pointing that out. The release notes have been updated again and have a PR up for the strip_prefix changes here #1070.

Why have we switched the repository name from "io_bazel_rules_kotlin" to "rules_kotlin"?

So that we are more in line with what other rules are doing and so that the rules name now matches the Github repository. Ex: bazelbuild/rules_android@ad1727a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants