Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Support #108

Closed
hsyed opened this issue Aug 8, 2018 · 9 comments
Closed

JS Support #108

hsyed opened this issue Aug 8, 2018 · 9 comments

Comments

@hsyed
Copy link
Contributor

hsyed commented Aug 8, 2018

I have javascript compilation working, and support in the builder for it. Libs can depend on other local libs. But currently that is it (can't depend on node modules I think).

I am not a JS developer so I don't know what would and wouldn't be idiomatic. I need a JS developer as a client. I need a real world example app using JS modules, rules_nodes and local local Kotlin libraries being used in concert in the example directory.

@thewoolleyman do you want to be this guy ? I can push the existing work after tidying it up in a separate branch.

@thewoolleyman
Copy link

@hsyed Yes, If you have something working, even minimal, I'd love to try it out.

I'm wanting to use it on a greenfield project, so my requirements should be minimal, and I want to be as flexible and bazel-idiomatic as I can (I mainly just REALLY don't want to use gradle or maven, which are the only other real choices for multiplatform kotlin projects). I can open issues (and fix if I can) for anything that doesn't work or I don't understand. So, seems like a great fit.

Thanks!
-- Chad

@hsyed
Copy link
Contributor Author

hsyed commented Aug 12, 2018

@thewoolleyman basic js support is available. It's not in master yet.

@thewoolleyman
Copy link

@hsyed Thanks! I'll start playing with it when I have time, and use this issue to report any problems I can't get past.

@thewoolleyman
Copy link

thewoolleyman commented Aug 14, 2018

I'm getting the following error when trying to build or fetch any of the node examples:

$ bazel fetch //examples/node/express:acme-routes
ERROR: error loading package 'examples/node/express': Extension file not found. Unable to load package for '@build_bazel_rules_nodejs//:defs.bzl': The repository could not be resolved
Building: no action

I'm probably missing something basic due to unfamiliarity with bazel, but I don't know what.

Thanks...

Edit: It would be helpful to put just a couple of lines in the js README.md with commands of how to run the examples.

@hsyed
Copy link
Contributor Author

hsyed commented Aug 14, 2018

Are you running the commands from the examples/node directory ? it is a nested workspace. If you run the commands from the root you will be in the root workspace.

@thewoolleyman
Copy link

Ah ok, it works from the examples/node directory.

I was confused because bazel build //examples/dagger:dagger_lib works fine from the root; I expected this to be the same.

@thewoolleyman
Copy link

@hsyed The example works fine for me (if run from the correct directory). I can build it and run the express app successfully.

I will try using it in a separate app when I get time.

My only suggestion is to add examples/node/node_modules to the .gitignore file.

@hsyed
Copy link
Contributor Author

hsyed commented Aug 15, 2018

node_modules should not be in the workspace. The example relies on rules nodejs to manage the node dependencies.

@cgruber cgruber added this to Needs triage in Intake Oct 16, 2019
@cgruber
Copy link
Collaborator

cgruber commented Feb 4, 2022

JS support exists at this point, but isn't well-maintained. I'm going to close this, as it is technically present, but we could use help from folks who have an interest in this capability.

There's also a larger kotlin multiplatform effort we are starting to think about, and this may be subsumed in that.

@cgruber cgruber closed this as completed Feb 4, 2022
Intake automation moved this from Needs triage to Closed Feb 4, 2022
@cgruber cgruber removed this from Closed in Intake Feb 4, 2022
@cgruber cgruber added this to To do in Release 1.6 via automation Feb 4, 2022
@cgruber cgruber removed this from To do in Release 1.6 Feb 4, 2022
@cgruber cgruber added this to Needs triage in Intake via automation Feb 4, 2022
@cgruber cgruber added status: closed - wontfix This will not be worked on. It is either working as intended, or otherwise will not be done. status: closed - fixed and removed status: open - needs triage status: closed - wontfix This will not be worked on. It is either working as intended, or otherwise will not be done. labels Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Intake
  
Needs triage
Development

No branches or pull requests

3 participants