Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add angular universal (SSR and PWA) to the example #1126

Closed
alexeagle opened this issue Sep 12, 2019 · 9 comments
Closed

Add angular universal (SSR and PWA) to the example #1126

alexeagle opened this issue Sep 12, 2019 · 9 comments
Labels
Can Close? We will close this in 30 days if there is no further activity enhancement

Comments

@alexeagle
Copy link
Collaborator

Probably for @Toxicable to do sometime.

@alexeagle
Copy link
Collaborator Author

@m0t0r did you do any experiments with this?

@alexeagle
Copy link
Collaborator Author

@alxhub and I had made a little Go program under Blaze that produces the service worker manifest. Maybe I should open-source that as a first step. Not sure when I'll have time.

@Toxicable
Copy link
Collaborator

Ill take a look at writing a rule which calls the @angular/pwa cli manifest generation tool.
Since that should be low cost to put in.

Then(or in parallel) I can take a look at doing some universal stuff aswell

@Toxicable Toxicable mentioned this issue Sep 22, 2019
4 tasks
@Toxicable
Copy link
Collaborator

I did a small start on running universal under bazel but ran into a few issues.
Ill revisit when we support v9 since that resolve a few of them

@marcus-sa
Copy link

Anything that I can help with regarding PWA support?

@alexeagle
Copy link
Collaborator Author

hey @marcus-sa can you get something working under https://github.com/bazelbuild/rules_nodejs/tree/master/examples/angular ? you can just cd into that directory and hack. If you get something working we can merge it to the example

@flolu
Copy link
Contributor

flolu commented Feb 25, 2020

Are there any updates on Bazel with Angular Universal? This is the last step for my migration to Bazel, and I really need it.
If there is no progress, then how could it be implemented?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Oct 15, 2020
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity enhancement
Projects
None yet
Development

No branches or pull requests

4 participants