Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharable github pages theme #2675

Closed
UebelAndre opened this issue May 14, 2021 · 9 comments
Closed

Sharable github pages theme #2675

UebelAndre opened this issue May 14, 2021 · 9 comments

Comments

@UebelAndre
Copy link
Contributor

馃殌 feature request

Description

It seems rules_nodejs has a github theme that's quite consistent with the official Bazel docs. Is this something that can be easily made sharable so other rules can benefit?

@alexeagle
Copy link
Collaborator

I have an even better idea. Let's just make one docsite that shows all the rules, adding features solves everyone's problem at once.
https://docs.aspect.dev

@UebelAndre
Copy link
Contributor Author

I love it! How do we setup repos to work with it?

@alexeagle
Copy link
Collaborator

I've got a script that populates the site, what repo would you want to add? Probably need a separate issue tracker for it

@UebelAndre
Copy link
Contributor Author

Really so long as rules_rust is there I'm happy. We're currently discussing how to avoid having generated docs committed in PRs (bazelbuild/rules_rust#695) so I was doing some investigation on how we could do this and setup versioned docs. I only know of this repo which has versioned docs which is what brought me to open this issue. I think it'd be awesome if there was something we could open an issue or PR on to add or update docs.

@mattem
Copy link
Collaborator

mattem commented May 20, 2021

I'm going to call this resolved by the Aspect doc site effort, rnj now uses the Aspect site as its own docsite SoT.

@mattem mattem closed this as completed May 20, 2021
@UebelAndre
Copy link
Contributor Author

The only thing that's not clear from this is what the process is for reporting issues in the new site.

@mattem
Copy link
Collaborator

mattem commented May 20, 2021

Good point, perhaps we can have a "docsite-issues" repo that the issues can be filed against, as the source repo is currently private, @alexeagle wdyt?

@UebelAndre
Copy link
Contributor Author

I think it'd be awesome if the site was open source and we could contribute things to it. But totally up to Alex. I just don't want to create unnecessary noise or distraction chasing down things related to the site.

@alexeagle
Copy link
Collaborator

yeah I'll figure out what should be open-source soonish. you can just ping me on slack in the meantime with any requests. That will be my real motivation to fix the process :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants