Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to define new proto_lang_toolchains? #40

Open
prestonvanloon opened this issue Dec 9, 2019 · 1 comment
Open

How to define new proto_lang_toolchains? #40

prestonvanloon opened this issue Dec 9, 2019 · 1 comment
Labels
documentation Improvements or additions to documentation P3 We're not considering to work on this, but happy to review a PR. (No assignee) question Further information is requested

Comments

@prestonvanloon
Copy link

I'm wondering how to write and use new proto_lang_toolchains.
Are there any examples or a design doc?

Related:

@Yannic
Copy link
Collaborator

Yannic commented Dec 9, 2019

We don't have a new proto_lang_toolchain yet (and there probably won't be a proto_lang_toolchain as we know it from native after the migration because it's insufficient in some [maybe most] cases). We'll provide docs/guides how to write proto rules when we start implementing the functionality (Currently planing to get the plumbing done in Q1).

Design doc for the migration is here: https://docs.google.com/document/d/1u95vlQ1lWeQNR4bUw5T4cMeHTGJla2_e1dHHx7v4Dvg/edit#

TL;DR: Create proto_toolchain that exposes the proto-related commandline options, migrate {cc,java,java_lite}_proto_library to Starlark (in parallel, migrate other rules like go_proto_library to the "framework"), and then figure out how to migrate proto_library. Everything will be as compatible as possible to the current status-quo, there'll be no "flag-day" where we migrate everyone from native to Starlark.

@Yannic Yannic added documentation Improvements or additions to documentation question Further information is requested labels Dec 9, 2019
@comius comius added the P3 We're not considering to work on this, but happy to review a PR. (No assignee) label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P3 We're not considering to work on this, but happy to review a PR. (No assignee) question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants