Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust_toolchain.target_json from a label to a json string #1445

Closed
UebelAndre opened this issue Jul 10, 2022 · 2 comments · Fixed by #1810
Closed

Update rust_toolchain.target_json from a label to a json string #1445

UebelAndre opened this issue Jul 10, 2022 · 2 comments · Fixed by #1810

Comments

@UebelAndre
Copy link
Collaborator

There have been a couple of cases where the functionality added in #836 to teach rust_toolchain to handle json files which represent fine grain information about platform triples has caused confusion or a gap in information in "starlark-land" when writing rules. A common issue is that while you can use target_json, you still need to provide os and in some cases, a "most similar" target_arch but that can differ from what target_json actually represents. Instead of supporting either a json or explicitly defined values, I think everything should be written to the toolchain. For folks who still want to use a json file to represent their platform triples, I suggest a repository rule be updated or introduced to allow translating the json file into explicit values available in "starlark-land".

@UebelAndre
Copy link
Collaborator Author

cc @hlopko

@hlopko
Copy link
Member

hlopko commented Jul 11, 2022

cc @krasimirgg

@UebelAndre UebelAndre changed the title Deprecate rust_toolchain.target_json Update rust_toolchain.target_json from a label to a json string Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants