Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_compile_action doesn't pass default_shell_env #2177

Open
granaghan opened this issue Oct 2, 2023 · 0 comments
Open

rustc_compile_action doesn't pass default_shell_env #2177

granaghan opened this issue Oct 2, 2023 · 0 comments

Comments

@granaghan
Copy link
Contributor

I have a CC toolchain where most of the "tools" are actually shell script wrappers that ensure only toolchain provided libraries are loaded. This involves some calls to readlink and dirname. rust_compile_actions doesn't set use_default_shell_env to True and as a result, these fail when rustc calls clang which in turn calls ld.lld. I found that setting use_default_shell_env = True resolved my issue.` Is this a change that can be made? Or should we consider adding a setting to either the rust toolchain or add another provider that can be applied to CC toolchains so we can let users configure this?

ctx.actions.run(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant