Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add a target for building a Cargo binary #520

Closed
UebelAndre opened this issue Dec 3, 2020 · 3 comments
Closed

RFC: Add a target for building a Cargo binary #520

UebelAndre opened this issue Dec 3, 2020 · 3 comments

Comments

@UebelAndre
Copy link
Collaborator

I've come across a desire to be able to use cargo to perform some simple operations.

Namely:

I've seen concerns about the use of Cargo within these rules but I do feel like being able to use it in sandboxes, deterministic ways would be beneficial for the rules. I understand this can be a slippery slope so if a target were to be added it it should be understood that it's to be used extremely selectively.

My hope for right now is to open a PR that adds an aspect for generating cargo metadata. This is probably required for #392 but could also have wider benefits.

Very interested in hearing more thoughts. 🙏

@UebelAndre UebelAndre changed the title RFC: Add a target for building Cargo RFC: Add a target for building a Cargo binary Dec 3, 2020
@UebelAndre
Copy link
Collaborator Author

Oh man, I didn't even know #413 was a thing.

@UebelAndre
Copy link
Collaborator Author

Well then I feel like this is way less controversial. I may make a PR for this soon.

@UebelAndre
Copy link
Collaborator Author

Gonna close this, I didn't realize cargo binaries could be found in the rust_toolchain toolchains. I think this binary should have it's own toolchain, which is something pointed out in #523

That should be the tracking issue for doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant