Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop flattening depsets in analysis #622

Open
hlopko opened this issue Mar 1, 2021 · 0 comments
Open

Stop flattening depsets in analysis #622

hlopko opened this issue Mar 1, 2021 · 0 comments
Labels
enhancement

Comments

@hlopko
Copy link
Member

hlopko commented Mar 1, 2021

There are numerous places in the rust rules where we flatten depsets using .to_list() method. That is frowned upon and can cause slow analysis and high memory use.

Not all instances can be fixed just yet - see bazelbuild/bazel#13132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hlopko