Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate aliases not supported #852

Closed
rbtcollins opened this issue Jul 22, 2021 · 5 comments
Closed

crate aliases not supported #852

rbtcollins opened this issue Jul 22, 2021 · 5 comments

Comments

@rbtcollins
Copy link

Ran into this failure:

error[E0433]: failed to resolve: use of undeclared crate or module `bytes_05`
   --> external/raze__async_compression__0_3_8/src/stream/macros/encoder.rs:58:41
    |
58  |             type Item = std::io::Result<bytes_05::Bytes>;
    |                                         ^^^^^^^^ use of undeclared crate or module `bytes_05`
    | 
   ::: external/raze__async_compression__0_3_8/src/stream/mod.rs:152:1
    |

The underlying cause can be found in async_compression's Cargo.toml: https://github.com/Nemo157/async-compression/blob/pr%C4%ABmum/Cargo.toml#L41

bytes-05 = { package = "bytes", version = "0.5.0", optional = true }

There was a dependency I was adding to reqwest 0.10, which uses async-compression with bytes-05 feature enabled, and that triggers the bug.

@illicitonion
Copy link
Collaborator

This is an issue with cargo-raze, rather than rules_rust itself (which I think may be addressed by google/cargo-raze#425) - I think this is a dupe of google/cargo-raze#424?

@rbtcollins
Copy link
Author

I'll re-file on raze, sorry for putting it in the wrong place. I don't think it is a dupe: 424 is about a an error case that cargo considers an error; this is about an error case that cargo considers success but bazel fails on.

@rbtcollins
Copy link
Author

google/cargo-raze#113 is nearly a dupe, except that this is up a level: crate a -> reqwest 0.10.10 -> bytes-with-features.

@hlopko
Copy link
Member

hlopko commented Jul 23, 2021

I think what @illicitonion meant was that the fix for this will happen in raze, not in this repository, so the issue should be filed over there. AFAIU there's nothing we need to do in the rules_rust, right?

@rbtcollins
Copy link
Author

yes, got that - sorry I didn't close this when I opened on the other repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants