New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve remote tests #87

Open

johnynek opened this issue Aug 18, 2016 · 0 comments

Member

johnynek commented Aug 18, 2016

see: #83

we need to have tests that verify that the rules work when using targets in remote repos. The testing is not clear there.

I think we need to set up two test WORKSPACES:

depends on the rules and defines some thrift/scala targets.
second repo depends on the first, and consumes some thrift classes from the target in 1.

johnynek mentioned this issue

Fix for thrift rule issue that manifests with remote repos #83

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment