Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension provides target/package completion for BUILD files #210

Closed
alexfrasson opened this issue Aug 16, 2020 · 5 comments
Closed

Extension provides target/package completion for BUILD files #210

alexfrasson opened this issue Aug 16, 2020 · 5 comments

Comments

@alexfrasson
Copy link

alexfrasson commented Aug 16, 2020

Feature Request

Enable Intellisense code completion for targets/packages within BUILD files.

#209 contains a draft on how that could be done. This is the first time I write something for a vscode extension, so there might be a lot of room for improvement.

@alexfrasson
Copy link
Author

It would be really cool if I could get some feedback regarding this feature. Would you guys be willing to support this? If so, could you have a look at the pull-request that I've submitted to see if the implementation is going in the right direction? I'm not a type/javascript nor a vscode extension developer, so I could really use another pair of eyes.

@cpsauer
Copy link

cpsauer commented Feb 10, 2022

@philwo, thoughts on closing this?

Happened to run back across it and remembered your merging in the changes in #209, above. That and (probably) #1 captures the remaining spirit better.

Would have tagged @coeuvre as the other owner who might be able to close things, but it seems like he's deleted his GitHub?

@laurentlb
Copy link
Contributor

I can close it :)

@philwo
Copy link
Member

philwo commented Feb 11, 2022

Thank you! 😊 @coeuvre should hopefully be back soon - his GitHub account was temporarily suspended for unknown reasons and we're still working with the support to get it unblocked again.

@cpsauer
Copy link

cpsauer commented Feb 11, 2022

😮
that's terrible! So sorry to hear, and the best of luck getting it back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants