Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #32

Open
smukherj1 opened this issue Dec 10, 2018 · 1 comment
Open

Add tests #32

smukherj1 opened this issue Dec 10, 2018 · 1 comment
Labels
type: feature request New feature or request

Comments

@smukherj1
Copy link
Contributor

We currently have no tests for the extension. VS Code extension testing framework described here https://code.visualstudio.com/docs/extensions/testing-extensions

We will need to add a starter test and include it in the PR verification CI job

@smukherj1 smukherj1 added the type: feature request New feature or request label Dec 10, 2018
@allevato
Copy link
Member

Yes, we definitely need some good coverage for our lower-level APIs here, at least. (I'm not sure what VS Code offers in the area of extension-based testing.)

We'll need to tweak some of our components where we invoke Bazel, Buildifier, etc. so that we can inject fakes that mock the results. We should probably wait on that until I make the changes that replace the XML-based processing with the proto output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants