Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Gem isn't including generated files #85

Closed
cdc97 opened this issue Nov 30, 2020 · 1 comment · Fixed by #102
Closed

Ruby Gem isn't including generated files #85

cdc97 opened this issue Nov 30, 2020 · 1 comment · Fixed by #102
Labels
help wanted Extra attention is needed rule::ruby_gem

Comments

@cdc97
Copy link

cdc97 commented Nov 30, 2020

Hi all,
I'm not especially familiar with bazel, so this may be more of a user error, but I was hoping I could get some help.
I am generating a ruby proto library (with grpc) using

load("@build_stack_rules_proto//ruby:ruby_proto_library.bzl", "ruby_proto_library")
ruby_proto_library(
    name = "rb_proto",
    has_services = True,
    deps = [
        ":v1",
    ],
    verbose = 3,
)

I then am trying to package the generated rb files into a ruby_gem. I can see both the proto generated rb files and the zip file from ruby_gem in my bazel-out, but my rb files aren't in my ruby_gem zip file when I unzip it. I only find the generated README and gemspec file.

Here's how I create my ruby_gem:

ruby_gem(
    name = "rb_gem",
    srcs = [":rb_proto"],
    gem_author_emails = [
        "my email here"
    ],
    gem_name = "my_proto_library",
    gem_version = "0.3.0"
)

What am I missing here? How do I ensure that my proto library generated ruby files show up in ruby_gem zip file?
Thanks!

@kigster
Copy link
Contributor

kigster commented Jul 8, 2021

If the gem files are not in the lib folder, I don't think they'd get included. There is a PR in progress that might fix that

@kigster kigster added help wanted Extra attention is needed rule::ruby_gem labels Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed rule::ruby_gem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants