Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Aether, go all in on coursier #276

Open
johnynek opened this issue Jan 4, 2020 · 2 comments
Open

Remove Aether, go all in on coursier #276

johnynek opened this issue Jan 4, 2020 · 2 comments

Comments

@johnynek
Copy link
Collaborator

johnynek commented Jan 4, 2020

I think we can reconceptualize this tool as a fixed lock file resolver for coursier. So we resolve all the dependencies then emit the hashes and the dependency relationships between them to a file and that file (not the jars) can be check in.

One output format would be the current output format, but we could also emit lock files for use with other build tools (e.g. sbt we could make a plugin that uses the lock file and only fetches the files).

What do you think @ianoc

@johnynek
Copy link
Collaborator Author

johnynek commented Jan 5, 2020

actually, the pro move would be to solve this:

coursier/coursier#1487

Then make bazel-deps a thin layer that converts such a lock file into bazel consumable data.

@ianoc
Copy link
Collaborator

ianoc commented Jan 5, 2020

Oh that would be pretty neat, having Bazel dips just possibly be the input yaml format -> outputs needed for bazel and moving the main logic upstream would I think be 💯 . The Aether resolver is buggy enough I can't imagine anyone could be recommended to use it, so seems like little win to keep it around and not simplify/stream line around just courier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants