Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using only java_import #311

Open
johnynek opened this issue Mar 24, 2022 · 1 comment
Open

Migrate to using only java_import #311

johnynek opened this issue Mar 24, 2022 · 1 comment

Comments

@johnynek
Copy link
Collaborator

currently we do a repo rule that downloads the file, then use java_import to wrap that, then use java_library to build the dependency graph.

This is because in the past, java_import didn't allow exports or runtime_deps so we couldn't set up the dependency graph.

That's no longer the case, so we could just directly use java_import and scala_import and reduce the number of targets and also have a side benefit of avoiding producing the empty jars that are produced by java_library.

@johnynek
Copy link
Collaborator Author

scala_import seems to be doing the right thing, btw. So, this is only for java libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant