Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Width calculation only is correct when the view takes up the whole width of the screen. #19

Closed
m-j-g opened this issue Jan 20, 2022 · 3 comments
Closed

Width calculation only is correct when the view takes up the whole width of the screen. #19

m-j-g opened this issue Jan 20, 2022 · 3 comments

Comments

@m-j-g
Copy link

m-j-g commented Jan 20, 2022

Nice work on the bottom modal.
There is an issue with the width calculation anytime the view doesn't take up the full screen (landscape tablets or web implementations). line 91 in giphy_tab_detail.dart is using (MediaQuery.of(context).size.width which is simply the width of the screen and not the width of the view. Using a LayoutBuilder to get the constraints maxwidth would fix this issue.

Screen Shot 2022-01-20 at 8 13 47 AM
@bazookon
Copy link
Owner

thank's, can you make a pull request fixing this issue?

@bazookon
Copy link
Owner

hello @m-j-g can you test this version if this issue has fixed?

@bazookon
Copy link
Owner

bazookon commented Feb 2, 2022

fixed in version 3.0.1

@bazookon bazookon closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@m-j-g @bazookon