Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsType Does Not Support Classes #94

Closed
bbatsche opened this issue Aug 8, 2023 · 1 comment
Closed

IsType Does Not Support Classes #94

bbatsche opened this issue Aug 8, 2023 · 1 comment
Labels
bug
Milestone
3.2.0

Comments

@bbatsche
Copy link
Owner

bbatsche commented Aug 8, 2023 •
edited
Loading

The IsType constraint does not actually support class names (maybe it did in PHPUnit 8?)

  • Add InstanceOf to the constraint factory
  • Add instanceOf() to the Value verifier
  • Check the $type being passed to the constraint factory and deprecate calling with a class name
@bbatsche bbatsche added the bug label Aug 8, 2023
@bbatsche bbatsche added this to the 3.2.0 milestone Aug 8, 2023
@bbatsche
Copy link
Owner Author

Bleh, nevermind. This isn't actually an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Verify
Status: Won't Do
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@bbatsche