Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of solarized-theme.el from theme path #370

Open
thomasf opened this issue Nov 20, 2019 · 2 comments
Open

get rid of solarized-theme.el from theme path #370

thomasf opened this issue Nov 20, 2019 · 2 comments
Milestone

Comments

@thomasf
Copy link
Collaborator

thomasf commented Nov 20, 2019

It is detected as a theme by the custom theme system even if it isn't.

The solution is maybe move the actual themes into their own subdirectory?

@thomasf thomasf added this to the v2.0 milestone Nov 20, 2019
@thomasf thomasf changed the title get rid of solarized-theme.el from theme load path get rid of solarized-theme.el from theme path Nov 20, 2019
@thomasf
Copy link
Collaborator Author

thomasf commented Jul 24, 2021

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

So if we just remove this file the code below would probable stop working correctly.

(use-package solarized-theme
  :ensure t
  :defer)

@bbatsov
Copy link
Owner

bbatsov commented Aug 23, 2021

The only reason that that file is there seems to be to have a file with the same name as the melpa package (?).

I think this can also be replaced with some package manifest file, but I never tried it. See https://www.gnu.org/software/emacs/manual/html_node/elisp/Multi_002dfile-Packages.html

For example, if we distribute version 1.3 of the superfrobnicator as a multi-file package, the tar file would be superfrobnicator-1.3.tar. Its contents would extract into the directory superfrobnicator-1.3, and one of these would be the file superfrobnicator-pkg.el.

Seems like a trivial change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants