-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support querying the server for installed drivers and supported drivers #28
Comments
One of the possible implementations is to query a fake file for every language (the list can be taken from src-d/enry or github/linguist), record failures and build the registry. Can take some time if implemented straightforward; I bet there is a docker API to check the existence of a container very fast. |
As for now, hardcode! 😆 https://github.com/src-d/ast2vec/blob/master/ast2vec/repo2nbow.py#L51 |
We should also expose which version of the driver is installed. |
Any updates? |
No updates, it's something we want to do at some point, but are focused on other tasks at the moment. |
The listing of supported drivers may be tricky, since the server may support custom images for some languages, and building a list of images through a complete list of languages and filtering sounds rather innefficient. In any case, we can start adding support for installed drivers, to begin with. |
As discussed with @mcuadros, we will add support both for server version and installed drivers, in the following way:
|
Clients should be able to query the server for installed drivers, as well as supported drivers (maybe through some metadata file published officially).
The text was updated successfully, but these errors were encountered: