Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bblfshd and go-client interdependency #317

Open
ncordon opened this issue Oct 21, 2019 · 1 comment
Open

bblfshd and go-client interdependency #317

ncordon opened this issue Oct 21, 2019 · 1 comment

Comments

@ncordon
Copy link
Member

ncordon commented Oct 21, 2019

bblfshd imports go-client here, and probably in other places, but at the same time go-client needs the bblfshd to be running in order to work. This is a cycle in dependencies that may be worth exploring and solving (in case it is a bug).

@creachadair
Copy link
Contributor

I believe it's not a strict cycle: bblfshd has a static dependency on some of the client library's support code, but I think not the client itself. The opposite is a runtime (RPC) dependency.

That said: This probably does mean we could factor out the shared code as a separate package, even if it continues to live in the client repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants