Style guide

[vmarkovtsev]

I propose two things here:

1. Explicitly state the style guide because writing C/C++ without a clear style guide is a nightmare

2. Since the only sane style guide I know is GC++SG I propose to adopt it, though it will require renaming struct names and header guards and reordering function arguments (at least).

[abeaumont]

We are already using google style guide, we should make it explicit in the README though.
Could you point an example of the problems you have already noticed?

[vmarkovtsev]

Sure.

Parameter order

node_api_find mutates find_ctx *ctx while the rest of the arguments are read-only, this should be moved to the last place.

find_ctx_set_len - length is read-only, thus the arguments should be swapped.

Naming

Structs:

node_iface -> NodeIface

node_api -> NodeApi

find_ctx -> FindCtx

Header guards

LUAST -> LIBUAST (this is the project name)

LUAST_SRC_NODE_API_H_ -> LIBUAST_SRC_UAST_H_

[abeaumont]

Thanks!

[abeaumont]

Solved by #22 and #23