Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Issues with version() and supported_languages() #141

Closed
vmarkovtsev opened this issue Jan 26, 2019 · 4 comments
Closed

Issues with version() and supported_languages() #141

vmarkovtsev opened this issue Jan 26, 2019 · 4 comments
Assignees
Labels

Comments

@vmarkovtsev
Copy link
Contributor

vmarkovtsev commented Jan 26, 2019

I run the following code and get:

import bblfsh
client = bblfsh.BblfshClient("0.0.0.0:9432")

print(client.version())
elapsed {
}
version: "v2.11.0"
build {
  seconds: -62135596800
}

print(client.supported_languages())
[name: "JavaScript"
language: "javascript"
version: "dev-adcd1b4"
status: "beta"
features: "ast"
features: "uast"
features: "roles"
]

The version string has a negative number of seconds and empty "elapsed".

The javascript driver version is reported to be "dev-adcd1b4", which does not help to check that it is 1.2.0 (which we strictly require since the newer versions do not work for us).

@vmarkovtsev vmarkovtsev changed the title Issues with verison() and supported_languages() Issues with version() and supported_languages() Jan 26, 2019
@juanjux
Copy link
Contributor

juanjux commented Jan 28, 2019

There are several issues here, neither of those culprit of the poor Python client :)

  • Missing elapsed and negative seconds seems to be a problem with the VersionResponse implementation in bblfshd since the returned value is directly the one from calling VersionRequest on the client without any added code.

  • Bad version for the Javascript driver, seems to be a problem with either the Javascript driver or the SDK (seems to be Ok in the latest drivers).

I'll confirm that the problems are in bblfshd/javascript-driver/sdk and reopen in the right projects adding you to the CC.

@juanjux
Copy link
Contributor

juanjux commented Jan 28, 2019

I've fixed the "elapsed" problem, as expected it was a bug in bblfshd, looking now at why the elapsed time is empty for that request type which won't be far from that other critter (so I'll tag bblfshd after this second one is fixed).

@juanjux
Copy link
Contributor

juanjux commented Jan 28, 2019

Elapsed time problem fixed too. I'll take a look at why the Javascript driver (and not later versions) didn't tag the version correctly in the driver now. Probably a bug in SDK.v1...

@juanjux
Copy link
Contributor

juanjux commented Feb 11, 2019

Closing this, I'll open an issue for the javascript driver version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants