Duplication of IDENTIFIER role

[zurk]

I found it in the output of this example https://gist.github.com/zurk/8f7dd974347925ae62c31d9441491613 for issue #94.

for self token we have role duplication:

<self>: ['IDENTIFIER', 'QUALIFIED', 'IDENTIFIER', 'EXPRESSION']

or for class1:
<class1>: ['IDENTIFIER', 'QUALIFIED', 'IDENTIFIER', 'EXPRESSION']

[juanjux]

Yes, I think that with the current UAST it will be unavoidable to have some duplicated roles, trough I'm pretty sure most of the current ones can be eliminated. There is a feature request in the SDK to automatically eliminate duplicates (bblfsh/sdk#174) but I don't want to implement it yet precisely to detect these easily avoidable cases.

[zurk]

Ok, got it!
It is not a big problem, so fix it when you are ready.

[juanjux]

Fixed by #112, thanks for reporting.

[juanjux]

Reopening, I checked that there are still some duplicated IDENTIFIER roles.

[juanjux]

Fixed by #122.