WebMock::Response::InvalidBody

[alexfalkowski]

Upgrading from version 1.20.0 to 1.20.2 I now get:

WebMock::Response::InvalidBody: must be one of: [Proc, IO, Pathname, String, Array]. 'Hash' given. Is this by design?

[bblimke]

@alexfalkowski yes, please see #427

It's ambiguous how the hash should be encoded. JSON, XML, url-encoded?

Could you please share an example that used to work for you? I'm surprised it did before :)

/cc @dapplebeforedawn

[alexfalkowski]

A simplified version of the code

json = JSON.parse "{}"
stub_request(:post, "www.example.com").with(body:  json)

Looking at the tests I see that it is silly doing it this way, though it works. I might have to rewrite the tests.

[bblimke]

This code only declares request body for the stub, not the response body. It would not be affected by the change in 1.20.2

[alexfalkowski]

When I am in front of the code I will post up the example (might be getting something wrong).

[alexfalkowski]

So looking at the code we do the following:

json = JSON.parse "{}"
stub_request(:get, url).to_return(body: json)

[alexfalkowski]

I will see if I can rewrite the tests :)

[alexfalkowski]

I have managed to rewrite the tests, due to this change it made mew realise the tests were wrong. Thanks guys :)

[markjlorenz]

That makes me very happy. What just happened to you is the reason I wrote
the PR to begin with.

[alexfalkowski]

Thanks mate 😃