Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in AllParameters::readParamLine #110

Closed
jan-provaznik opened this issue Dec 14, 2022 · 3 comments
Closed

Inconsistency in AllParameters::readParamLine #110

jan-provaznik opened this issue Dec 14, 2022 · 3 comments

Comments

@jan-provaznik
Copy link
Contributor

The comment claims the function AllParameters::readParamLine throws for unknown parameters.

The implementation, however, does not throw anything. Instead, the errors are printed out to the standard error stream.

@ctribes
Copy link
Contributor

ctribes commented Dec 14, 2022

The comment is changed for the next release.

Note that unrecognized parameters can trigger an exception or not (just a message) when doing RunParams::checkAndComply. This is managed by REJECT_UNKNOWN_PARAMETERS.

@ctribes ctribes closed this as completed Dec 14, 2022
@jan-provaznik
Copy link
Contributor Author

Thanks for the clarification and the fix.

@ctribes
Copy link
Contributor

ctribes commented Dec 15, 2022

I am also changing the default value for REJECT_UNKNOWN_PARAMETERS in NOMAD 4.3 (now it is true instead of false) so that an exception is triggered for unregistered params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants