Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] --bindgen flag has misleading behavior #71

Closed
ebraraktas opened this issue Aug 3, 2022 · 1 comment
Closed

[BUG] --bindgen flag has misleading behavior #71

ebraraktas opened this issue Aug 3, 2022 · 1 comment

Comments

@ebraraktas
Copy link

ebraraktas commented Aug 3, 2022 •
edited

I was using cargo-ndk with custom BINDGEN_EXTRA_CLANG_ARGS enviroment variable for so long, but it seems that new versions cargo-ndk overwrites that environment variable whether you pass --bindgen or omit it.

In my opinion, this commit in this PR must be reverted (in other words, else block must be deleted). --bindgen flag must be an opt-in flag and it mustn't change behavior if you omit it.

I can create a PR for this if you like.
@bbqsrc
Copy link
Owner

bbqsrc commented Aug 4, 2022

Fixed in v2.11.0.

@bbqsrc bbqsrc closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbqsrc @ebraraktas