Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lazyCommands map, directly declare all commands #8

Closed
bbredesen opened this issue Mar 6, 2023 · 0 comments · Fixed by #38
Closed

Remove lazyCommands map, directly declare all commands #8

bbredesen opened this issue Mar 6, 2023 · 0 comments · Fixed by #38
Labels
enhancement New feature or request

Comments

@bbredesen
Copy link
Owner

bbredesen commented Mar 6, 2023

lazyCommands is a map that is populated at runtime through init(). Commands will never be added to the map or changed at runtime though...they are generated from vk.xml and are set in stone at compile time.

Eliminate the lazy commands map and declare each vkCommand individually in a var( ... ) block. Commands will still be lazy-evaluated when first called. I would expect there to be some startup performance improvement, but it is worth benchmarking both models before committing this change.

@bbredesen bbredesen added the enhancement New feature or request label Mar 6, 2023
@bbredesen bbredesen mentioned this issue Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant