Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTPower shall support unique binning. #496

Closed
rainwoodman opened this issue May 31, 2018 · 2 comments
Closed

FFTPower shall support unique binning. #496

rainwoodman opened this issue May 31, 2018 · 2 comments

Comments

@rainwoodman
Copy link
Member

FFTPower shall support unique binning where each bin is guarenteed to have at most one |k|.

This is to ease comparison with theory curves, because

<P(k)> != P(<k>)
@rainwoodman
Copy link
Member Author

PR #497 helps this situation without getting into details of implementing the unique binning.

The current issue is that kedges are computed before the 3d mesh is generated (inside compute_3d_power); but the k modes are only available during that function. (When ComplexField is created). It should be simple to hack this.

I checked that for 3D modes, the number of unique |k| values scales roughly like N^2.15. So for a 1024 mesh it should be less than a million unique |k| modes. This is definitely a resonable size.

@rainwoodman
Copy link
Member Author

This is already supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant