Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

終了コマンドを削除する #205

Closed
ochaochaocha3 opened this issue May 25, 2020 · 0 comments · Fixed by #208
Closed

終了コマンドを削除する #205

ochaochaocha3 opened this issue May 25, 2020 · 0 comments · Fixed by #208
Assignees
Labels
IRCボット分離独立化 IRCボット分離独立化のための作業

Comments

@ochaochaocha3
Copy link
Member

ochaochaocha3 commented May 25, 2020

終了コマンド($quitCommand)をIRCボットに移動することで、 ボット終了処理 BCDice#quit を取り除く。BCDice IRCでは画面のボタンで安定して接続切断できるようになった(その後の再接続にも影響しない)ので、終了コマンドが不要になった。

git grep -n -i quit の結果

src/bcdice.rb:9:  def quit; end
src/bcdiceCore.rb:32:# 終了時はボットにTalkで「お疲れ様」と発言します。($quitCommandで変更出来ます。)
src/bcdiceCore.rb:72:    @quitFunction = nil
src/bcdiceCore.rb:76:  attr_accessor :quitFunction
src/bcdiceCore.rb:213:    when $quitCommand
src/bcdiceCore.rb:214:      quit
src/bcdiceCore.rb:230:  def quit
src/bcdiceCore.rb:231:    @ircClient.quit
src/bcdiceCore.rb:233:    if @parent.quitFunction.nil?
src/bcdiceCore.rb:237:      @parent.quitFunction.call()
src/bcdiceCore.rb:241:  def setQuitFuction(func)
src/bcdiceCore.rb:242:    @parent.quitFunction = func
src/bcdiceGui.rb:438:    @ircBot.setQuitFuction(proc { destroy })
src/bcdiceGui.rb:477:    @ircBot.quit
src/configBcDice.rb:16:$quitCommand = 'お疲れ様';           # 終了用のTalkコマンド
src/configBcDice.rb:17:$quitMessage = 'さようなら'; # 終了時のメッセージ
src/irc/ircBot.rb:227:  def quit
src/irc/ircBot.rb:228:    debug('quitCommand')
src/irc/ircBot.rb:233:    post(QUIT, encode($ircCode, $quitMessage))
src/irc/ircBot.rb:236:  def setQuitFuction(func)
src/irc/ircBot.rb:238:    bcdice.setQuitFuction(func)
src/irc/torgtaitaiIRC.rb:70:  def quitCommand(arg); end
@ochaochaocha3 ochaochaocha3 created this issue from a note in IRCボット分離独立化 (To do) May 25, 2020
@ochaochaocha3 ochaochaocha3 self-assigned this May 25, 2020
@ochaochaocha3 ochaochaocha3 added the IRCボット分離独立化 IRCボット分離独立化のための作業 label May 25, 2020
@ochaochaocha3 ochaochaocha3 moved this from To do to In progress in IRCボット分離独立化 May 25, 2020
@ochaochaocha3 ochaochaocha3 changed the title 終了コマンドをIRCボットに移動する 終了コマンドを削除する May 27, 2020
ochaochaocha3 added a commit that referenced this issue May 27, 2020
IRCボット分離独立化 automation moved this from In progress to Done May 28, 2020
ysakasin pushed a commit that referenced this issue Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRCボット分離独立化 IRCボット分離独立化のための作業
Development

Successfully merging a pull request may close this issue.

1 participant