Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In address data prep, make site/address ids immutable #375

Closed
mraross opened this issue Jun 3, 2019 · 1 comment
Closed

In address data prep, make site/address ids immutable #375

mraross opened this issue Jun 3, 2019 · 1 comment

Comments

@mraross
Copy link
Contributor

mraross commented Jun 3, 2019

Problem
Currently, site ids are mutable; they are different every time an address data integration is performed (e.g., currently monthly). If an application makes a geocoder request, hangs on to the site id for dayw or weeks, then uses the id in another geocoder api request such sites/{siteID}/subsites, the id will likely be invalid by then. This problem will become more apparent if and when we start more frequent data integrations.

Proposed solution
Make site ids immutable. The simplest way to do this is to keep a permanent table of site ids by fullAddress. Each data integration, look up a fullAddress to see if there is already an id for it. If no id is found, create a new id and add a entry to the table for next time. Can also keep track of the date the site id was created and the last time it was used in a new data integration.

@mraross
Copy link
Contributor Author

mraross commented Sep 21, 2019

Issue moved to bcgov/ols-geocoder #31 via ZenHub

@mraross mraross closed this as completed Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants