Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search module addition to base build #15

Closed
18 tasks done
NicoledeGreef opened this issue Jul 13, 2023 · 3 comments
Closed
18 tasks done

Search module addition to base build #15

NicoledeGreef opened this issue Jul 13, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Sprint 3 July 13 - July 26

Comments

@NicoledeGreef
Copy link
Collaborator

NicoledeGreef commented Jul 13, 2023

OP timer

https://openplus.monday.com/boards/4092908516/pulses/4806164629


This feature support the following requirements

To be characterized at the base-build meeting

Additional context

Depends on #14

Proposed solution

Create a custom module named bcbb_search that:

  • installs search_api
  • installs facets
  • creates search_index display mode
  • add title and body to search_index display
  • creates the search results view site_search
  • create search page at /search/site
  • configure search_api to:
    • use Drupal's DB for search index
    • search content / basic page
    • bundle data source is basic page
    • in search fields, rendered item uses search_index display mode
    • full text search
    • don't include rendered item for view mode > basic page
    • for content, add created, uid, uid:entity:name, changed, type, body, status, title
    • for facets, make sure the content type facet is available on search/site
    • csv download should be available, but disabled by default

Estimated level of effort

  • 3 days

Definition of done (DoD)

  • bcbb_search is enabled by default when a new site is created
  • search results appear at search/site
  • there is a block with a facet for content type on the right of the results page

Note: Important! once this works in base-build we need to make sure data catalogue is using it with data catalogue specific config done locally on that project.

Testing

Automated functional tests

  • I have written functional tests for this feature
  • I have run the functional tests and they pass
@NicoledeGreef NicoledeGreef added enhancement New feature or request Sprint 3 July 13 - July 26 labels Jul 13, 2023
@CraigClark
Copy link
Collaborator

@chrislaick and @victoriazou

We are not sure if this module should be enabled by default on the base-build. If we do enable it, you are set to go with search when you create the project. Otherwise you need to enable the module. Once enabled, you would get all the default config.

how would you like us to proceed?

@chrislaick
Copy link
Collaborator

@CraigClark and @victoriazou

My vote is to have it disabled by default on the base build. I'm not 100% sure that all future Drupal projects will require search, although many will. If it's easily enabled and config is loaded, I think that is sufficient.

@CraigClark
Copy link
Collaborator

I've tested this locally with a clean install of the base-build and all is good.

@CraigClark CraigClark mentioned this issue Jul 26, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Sprint 3 July 13 - July 26
Projects
Development

No branches or pull requests

4 participants