Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a CIF Administrator, I want to filter milestones by status (late, complete...) on the projects page, so that I can identify projects which need work #1809

Closed
5 of 21 tasks
pbastia opened this issue Jul 19, 2023 · 5 comments
Assignees
Labels
Giraffe 🦒 Work related to Team Giraffe High Priority High priority tickets/Issues User Story A User Story issue type

Comments

@pbastia
Copy link
Contributor

pbastia commented Jul 19, 2023

Description:

Ideally, a drop-down filter similar to project status, but for the 'lateness' status

Acceptance Criteria:

Given I am a CIF admin
When I am on the page with the projects table
Then I see a filter for the "Milestone Due" column
and when I filter by milestone (late, completed, etc.) status, only the projects with the chosen status appear in the table

Development Checklist:

  • see the project status filter for a (simplified) example
  • add a filter for milestone status to the graphql query
  • This likely needs a new custom filter. I don't think we can use the SearchableDropdownFilter here because it relies on the item in the dropdown mapping to values in the the database. The statuses of {Late, Completed, On Track} are synthetically applied on the front-end based on temporal data returned by the query. "Late" does not map to a database value, it applies to a range of time where the dueDate is before now() and where submittedDate is null.
  • We probably need a computed column too.
  • Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

  • User story is included
  • User role and type are identified
  • Acceptance criteria are included
  • Wireframes are included (if required)
  • Design / Solution is accepted by Product Owner
  • Dependencies are identified (technical, business, regulatory/policy)
  • Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

  • Acceptance criteria are tested by the CI pipeline
  • UI meets accessibility requirements
  • Configuration changes are documented, documentation and designs are updated
  • Passes code peer-review
  • Passes QA of Acceptance Criteria with verification in Dev and Test
  • Ticket is ready to be merged to main branch
  • Can be demoed in Sprint Review
  • Bugs or future work cards are identified and created
  • Reviewed and approved by Product Owner

Notes:

@pbastia pbastia added Backlog Refinement Tickets that require further refinement User Story A User Story issue type labels Jul 19, 2023
@pbastia pbastia changed the title As a CIF Administrator, I want to filter milestones by status (late, complete...) on the project page, so that I can identify projects which need work As a CIF Administrator, I want to filter milestones by status (late, complete...) on the projects page, so that I can identify projects which need work Jul 19, 2023
@BCerki
Copy link
Collaborator

BCerki commented Aug 3, 2023

@dleard
Copy link
Contributor

dleard commented Aug 3, 2023

This likely needs a new custom filter. I don't think we can use the SearchableDropdownFilter here because it relies on the item in the dropdown mapping to values in the the database. The statuses of {Late, Completed, On Track} are synthetically applied on the front-end based on temporal data returned by the query. "Late" does not map to a database value, it applies to a range of time where the dueDate is before now() and where submittedDate is null.

@Sepehr-Sobhani
Copy link
Contributor

I second what Dylan said. We probably need a computed column too.

@rdromey rdromey added Giraffe 🦒 Work related to Team Giraffe High Priority High priority tickets/Issues and removed Backlog Refinement Tickets that require further refinement labels Aug 3, 2023
@BCerki BCerki self-assigned this Aug 8, 2023
@patriciarussellCAS
Copy link

Initial testing of the filter didn't work properly but when I navigated away and came back it did. @BCerki @Sepehr-Sobhani are you able to have a look?

@patriciarussellCAS
Copy link

Working now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Giraffe 🦒 Work related to Team Giraffe High Priority High priority tickets/Issues User Story A User Story issue type
Projects
None yet
Development

No branches or pull requests

6 participants