Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gert #24

Closed
boshek opened this issue Oct 14, 2021 · 1 comment
Closed

Use gert #24

boshek opened this issue Oct 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@boshek
Copy link
Contributor

boshek commented Oct 14, 2021

Use gert instead of a system call here:

dipr/R/dipr-update.R

Lines 37 to 41 in b821507

git_clone_cmd <- glue::glue("git clone https://projectsc.popdata.bc.ca/shares/dipr {git_clone_dir}")
} else {
git_clone_cmd <- glue::glue("git clone --branch {ref} https://projectsc.popdata.bc.ca/shares/dipr {git_clone_dir}")
}
clone_status <- system(git_clone_cmd, show.output.on.console = quiet)

@boshek boshek added the enhancement New feature or request label Oct 14, 2021
@boshek
Copy link
Contributor Author

boshek commented Dec 6, 2021

Probably not worth the hassle

@boshek boshek closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boshek