Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocwa import tools #26

Merged
merged 20 commits into from
Nov 29, 2021
Merged

Ocwa import tools #26

merged 20 commits into from
Nov 29, 2021

Conversation

ateucher
Copy link
Contributor

Tools (one exported function: ocwa_branch_export()) to prepare the repo for import into OCWA by:

  1. Creating a new branch
  2. Removing files that can't be imported - these are listed in the _ocwaignore file in the root of the repo
  3. Cleaning README.md to comment out references to images and links that won't be available in the SRE. Basically at this point the sticker and the badges.
  4. Committing the changes from 2 and 3 to the new branch and pushing that to GitHub. This branch can then be used as the basis for an import into OCWA.

@ateucher ateucher requested a review from boshek November 10, 2021 21:53
Copy link
Contributor

@boshek boshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Well done. I think adding a NEWS item and also your name into the DESCRIPTION file would be worthwhile in this PR.

Just a couple questions.

R/utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
.Rbuildignore Show resolved Hide resolved
@ateucher
Copy link
Contributor Author

@boshek for NEWS and DESCRIPTION - what version should I set? A dev version or 1.1 or???

@boshek
Copy link
Contributor

boshek commented Nov 29, 2021

I think leave it as a dev version? My usual process for versioning is that when the inside/outside repos are in the same state, you version it. Open to other versioning schemes though.

@ateucher ateucher merged commit 5eae011 into master Nov 29, 2021
@boshek boshek mentioned this pull request Dec 6, 2021
@boshek boshek deleted the ocwa-import-tools branch March 10, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants