Skip to content

Latest commit

 

History

History
31 lines (24 loc) · 1.13 KB

PR-Process.md

File metadata and controls

31 lines (24 loc) · 1.13 KB
Raw

PR Process for Entities Team Drafted by Severin & Shahriar on the following process for PR´s: Goals: Merge code ASAP, not letting it languish

  1. When creating PRs, Assign it to yourself & wait to make sure github actions run lint and unit tests successfully before assigning reviewers. a) If tests don’t run automatically, dev must run them manually before assigning reviewers.
  2. Assign 2 reviewers
  3. Send a message in the registries-Entities rocketchat channel, tagging the 2 reviewers & including a link to the PR a) Reviewers can refuse due to load b) Team can suggest others
  4. Only the person starting a conversation can resolve it.
  5. PRs must be looked at by reviewers within 24hrs of receieving the PR.
  6. Last reviewer must squash and merge.

PR-Process Assets Team

  1. @mention the reviewers on rocket
  2. chat and include a link to the PR
  3. It should be reviewed within an hour
  4. We've been reviewing in 5-10 minutes

PR Process for Team Relationships

  1. Assign any no. of reviewers
  2. At least two assignees must approve
  3. Communicate in RocketChat in channel "relationships-developers"