New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the DirectorListSm component #1096

Closed

1 of 4 tasks

WalterMoar opened this issue Aug 21, 2019 · 1 comment

Closed

1 of 4 tasks

Modernize the DirectorListSm component #1096

WalterMoar opened this issue Aug 21, 2019 · 1 comment

Labels

ENTITY Priority3 techdebt

Contributor

WalterMoar commented Aug 21, 2019 •

edited by severinbeauvais

Loading

Ideally, this component should really be replaced with the Directors component in "readonly" mode (may need to be implemented). Otherwise:

The component should be updated to:

Be a TypeScript class component.
~~Use only properties and events for the component interface.~~ NOT APPLICABLE: this component does not use any props
~~Use JSON Schema validation~~ NOT APPLICABLE: this component does not perform input
~~Eliminate watches, refs, and store usage unless absolutely avoidable.~~ NOT APPLICABLE: this component only uses 1 store object

WalterMoar added ENTITY techdebt Priority3 labels

severinbeauvais changed the title ~~Moidernize the DirectorListSm component~~ Modernize the DirectorListSm component

severinbeauvais closed this as completed

Collaborator

severinbeauvais commented Mar 18, 2020

This was done as part of other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment