Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXA for PPR documents generated via the new report API #13972

Closed
RFK250 opened this issue Oct 20, 2022 · 5 comments
Closed

UXA for PPR documents generated via the new report API #13972

RFK250 opened this issue Oct 20, 2022 · 5 comments

Comments

@RFK250
Copy link

RFK250 commented Oct 20, 2022

Description

This ticket is just the outstanding UXA on #13161 so we can advance that ticket through QA.

    @RFK250 - we ran out of time to review so far - if you want to move this along, we can do UXA as a separate spin off UXA ticket if you want to create a new one and leave it in this column?

Originally posted by @tlebedovich in #13161 (comment)

@tlebedovich
Copy link

tlebedovich commented Oct 26, 2022

@doug-lovett UXA for non-large PPR search results:

  • added/deleted badge positioned too close when shown under text items:

Screen Shot 2022-10-26 at 2.02.27 PM.png

Screen Shot 2022-10-26 at 1.54.49 PM.png


  • Adjust TOC text wrapping/alignment:

Screen Shot 2022-10-26 at 1.57.11 PM.png

Screen Shot 2022-10-26 at 1.49.49 PM.png


  • Can we align the address columns to the other text columns?
  • Remove the additional gray divider lines that appear BETWEEN History items (the blue header/line is enough of a divider, keep the white space but just remove the additional gray lines):

Screen Shot 2022-10-26 at 1.50.25 PM.png

@tlebedovich
Copy link

@doug-lovett - for the TOC rows, looks like all rows are double height now. Can we keep the row heights the original height when there is no text wrapping onto two lines, and only grow the row height for the rows where text needs to wrap onto two lines? (ie only the rows that have wrapping text will be taller).

Screen Shot 2022-10-27 at 9.43.10 AM.png

@doug-lovett
Copy link
Collaborator

doug-lovett commented Oct 27, 2022

@tlebedovich Actually the spacing has not changed and is identical to the PROD reports. Only the text alignment changed. Below are some updated examples.

https://app.zenhub.com/files/157936592/6378d717-0094-44eb-8c53-1493450e9d97/download
https://app.zenhub.com/files/157936592/e8bc1c37-4d39-40a3-8b35-af897c9c00b9/download

@tlebedovich
Copy link

looks great thanks doug!

@PCC199 PCC199 closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants