Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPR Registration Table #18923

Closed
9 tasks done
mstanton1 opened this issue Dec 7, 2023 · 5 comments
Closed
9 tasks done

PPR Registration Table #18923

mstanton1 opened this issue Dec 7, 2023 · 5 comments
Assignees
Labels

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Dec 7, 2023


  • When adding an existing registration to PPR table, should autoscroll in table to show newly added registration at top of table and its missing 5 sec green user feedback highlight and snackbar
  • When I file any type of registration/transaction, should autoscroll in table to show newly added registration at top of table and its missing 5 sec green user feedback highlight and snackbar appearing way too low on screen

  • Create new Security Agreement Button Dropdown:
  • Can not access all the Security Agreements (QS/General User) dropdown cut off
  • dropdown should appear outside/on top of frame and left-justified

DEV:

Screen Shot 2023-12-13 at 6.05.25 PM.png

TEST (what is should look like):
Screen Shot 2023-12-14 at 4.02.03 PM.png


  • View Amendments text links missing underline to indicate its a link

Screen Shot 2023-12-14 at 4.20.34 PM.png


Table Filters


  • Missing default field text for "Registration Type" filter and clear X button appears on rollover before user even select on item:

Screen Shot 2023-12-07 at 2.37.03 PM.png


  • status filter missing default text and clear X button appears on rollover before user even selects an item:

Screen Shot 2023-12-07 at 4.22.02 PM.png


  • If you select a Date range, the Date filter is missing X button in filter field (only appears on rollover):

Screen Shot 2023-12-07 at 3.03.00 PM.png


  • Date picker gets cuts if date picker is taller than the table because its now sitting inside of the table frame (sits above in test):

Screen Shot 2023-12-14 at 4.24.34 PM.png


  • When adding a registration to the registration table, if something other than 7 digits is entered an error is displayed. The error is currently displaying in the box where the registration number being added is inserted which makes it tricky to actually see the number being added. In TEST/PROD the error displays under the box so it's still visible.

Current:
image.png

Expected
image.png

@bcgov bcgov deleted a comment from LizGovier Dec 14, 2023
@tlebedovich
Copy link

@cameron-eyds ready to go

@LizGovier
Copy link
Collaborator

LizGovier commented Dec 18, 2023

cc @tlebedovich could you verify that what I found below should be the correct functionality

  • PPR Registration Table / Dropdown / Start New PPR
    When I type to start a new PPR, the PPR I'm searching for does not show unless I open the dropdown. When I type, the search should cover everything in the dropdown.
    Video:
    Private Zenhub Video

  • I click the dropdown 'Start new PPR' and expand a column. I then click off and back on the dropdown, the expandable items should always be collapsed.
    Video
    ** Dev Note: Currently in TEST it preserves the state of expanded and collapsed and doesn't default to collapsed always.

Private Zenhub Video

@doug-lovett
Copy link
Collaborator

doug-lovett commented Jan 5, 2024

I'll QA this one.

  1. When adding an existing registration to PPR table, should autoscroll in table to show newly added registration at top of table and its missing 5 sec green user feedback highlight and snackbar. Fix verified adding 001073M.
  2. When I file any type of registration/transaction, should autoscroll in table to show newly added registration at top of table and its missing 5 sec green user feedback highlight and snackbar appearing way too low on screen. Fix verified with an amendment on 100390P.
  3. Non-staff create new Security Agreement Button Dropdown. Fix verified with BCREG0018 DIVYA HOLDINGS LTD.
  4. View Amendments text links missing underline to indicate its a link. Fix verified.
  5. Missing default field text for "Registration Type" filter and clear X button appears on rollover before user even select on. Fix verified.
  6. status filter missing default text and clear X button appears on rollover before user even selects an item. Fix verified.
  7. If you select a Date range, the Date filter is missing X button in filter field (only appears on rollover). Fix verified.
  8. Date picker gets cuts if date picker is taller than the table because its now sitting inside of the table frame (sits above in test). Fix verified.
  9. When adding a registration to the registration table, if something other than 7 digits is entered an error is displayed. The error is currently displaying in the box where the registration number being added is inserted which makes it tricky to actually see the number being added. In TEST/PROD the error displays under the box so it's still visible. Fix verified.
  10. When I type to start a new PPR, the PPR I'm searching for does not show unless I open the dropdown. When I type, the search should cover everything in the dropdown. Fix verified.
  11. I click the dropdown 'Start new PPR' and expand a column. I then click off and back on the dropdown, the expandable items should always be collapsed. Fix verified.

@doug-lovett
Copy link
Collaborator

@chdivyareddy fixes verified in DEV for all issues identified in this ticket.

@chdivyareddy
Copy link
Collaborator

@doug-lovett , thank you!! Please move it to QA in Progress pipeline once it is Done:)

@PCC199 PCC199 closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants