Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer: Add unit tests #21136

Open
kialj876 opened this issue May 3, 2024 · 0 comments
Open

Importer: Add unit tests #21136

kialj876 opened this issue May 3, 2024 · 0 comments
Labels
BTR Business Transparency Register techdebt

Comments

@kialj876
Copy link
Collaborator

kialj876 commented May 3, 2024

This is a very important piece of the search process and it is not covered by any unit tests. Setting up a test environment for this is quite complex which is way it was put off in the past.

Proposal:

  • mock out collect btr data function (removes need for btr db setup)
  • mock out collect colin data function (removes need for colin db setup)
  • mock out collect lear data function (removes need for lear db setup)
  • mock out solr connection for reindex prep
  • mock out token call and bor-api import call

Tests will secure that the records are being parsed correctly from what we expect to receive from the db. There is complex logic involved here so these will be very valuable tests even though the db data collection is mocked

@kialj876 kialj876 added BTR Business Transparency Register techdebt labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BTR Business Transparency Register techdebt
Projects
None yet
Development

No branches or pull requests

1 participant