Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: implement "Existing Business Information" component (step 1) - PART 3 #21138

Closed
17 of 21 tasks
severinbeauvais opened this issue May 3, 2024 · 11 comments
Closed
17 of 21 tasks
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented May 3, 2024

This is work continued from #20889 (that exceeded the scope of that ticket, or had outstanding dependencies).

  • remove Authority Name
  • remove authorization confirmation checkbox
  • remove Type of Business radio buttons and update conditional upload and validation - UNDER DISCUSSION
  • update review page per latest designs
  • hide Identifying Number on review page if user chose expro lookup path obsolete
  • add enum for LOOKUP/MANUAL not needed, used 'LOOKUP' | 'MANUAL' instead
  • change Your Business in Home Jurisdiction icons to home_work home-city-outline (step 1 and review page)
  • fetch xpro business data from COLIN (may need new COLIN_API environment key)
  • add readonly support for Jurisdiction/NestedSelect shared components
  • update fields for active vs historical expros
  • display user-friendly home jurisdiction
  • remove radio buttons for ULC
  • add conditional affidavit
  • finish affidavit upload
  • fix Undo button that shouldn't show after you have undone
  • verify Court Order / POA is on Review page and working for all entity types (staff only), same as IA
  • update filing save + resume
  • update/add unit tests for new code will be done in Create UI - Add unit tests for everything not done yet #19524
  • verify Clicking on ULC radio button triggering an in component validation. #21308 and close if resolved
  • add rules for BN
  • fix validations (expro and manual components)
@severinbeauvais severinbeauvais added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. blocked UX Assurance labels May 3, 2024
@severinbeauvais severinbeauvais changed the title Create UI: implement "Existing Business Information" component (step 1) - PART 2.5 Create UI: implement "Existing Business Information" component (step 1) - PART 3 May 3, 2024
@severinbeauvais
Copy link
Collaborator Author

Blocked while a waiting final requirements from the business:

  • should we pre-populate some fields (from COLIN data), and which ones?
  • which fields should be editable or readonly?

Also, @yuisotozaki, please update designs if needed to account for entity type radio boxes + confirmation checkbox?

@severinbeauvais
Copy link
Collaborator Author

From Elizabeth Espinosa:

  1. Extrapro name pulled from Colin corresponding to the A# is NOT editable.
  2. Other information pulled from Colin related to the A# should be displayed AND be editable.

@severinbeauvais
Copy link
Collaborator Author

To do: add hints to dates as below.

image.png

@severinbeauvais
Copy link
Collaborator Author

Test Notes

All the functionality (including tooltips, validation and save/resume) is complete for the business search component:

image.png

Most of the functionality (including tooltips, validation and save/resume) is complete for the manual entry component (missing: affidavit upload):

image.png

Most of the functionality (including tooltips, validation and save/resume) is complete for the continuation authorization component (missing: updated file upload design):

image.png

All the functionality is complete for the review and confirm page.

Also affected by this feature is the date picker for:

  1. Start Date (firm registration)
  2. Resolution Date (coop dissolution)
  3. Dissolution Date (firm dissolution)

I have verified all the above.

@NaveenHebbale
Copy link
Collaborator

NaveenHebbale commented May 27, 2024

@severinbeauvais

Wether we need to create to fix this entry and output as shown below. If already , ticket is available , please ignore this
The below fields are not saved.
Home Jurisdiction
Authorization Date
Expiry date
Input Entry
image.png

Review and Confirm page

image.png

@severinbeauvais
Copy link
Collaborator Author

Naveen, where are you testing this? I just tried in Dev and, upon successful business search, the fields are all saved to the draft, and I can resume them later.

Sample ULC continuation in: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TyS39DGw5j&accountid=3040

Sample CBEN continuation in: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TbY9bJGz0k&accountid=3040

@NaveenHebbale
Copy link
Collaborator

@severinbeauvais: Sorry there was some error loading dev
It is working -
Only - Registration Number in Home Jurisdiction, this field is not available for the input page

https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-home?id=TcAD4Re5m9&accountid=668

image.png

@severinbeauvais
Copy link
Collaborator Author

The UI design does not show a prompt for Registration Number in Home Jurisdiction when the business is an expro. That information is supposed to come from COLIN. However, you are testing in Dev environment and it seems that COLIN data there is incomplete.

@yuisotozaki
Copy link
Collaborator

Ready for QA.

@ketaki-deodhar
Copy link
Collaborator

Test scenario:

  • Extrapro Historical - Looks good
  • Extrapro Active - Looks good
  • Extrapro ULC - Looks good
  • Manual Entry - Looks good

@NaveenHebbale
Copy link
Collaborator

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance
Projects
None yet
Development

No branches or pull requests

4 participants