Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'pre' lifecycle hook #695

Closed
cvarjao opened this issue May 18, 2018 · 3 comments
Closed

Missing 'pre' lifecycle hook #695

cvarjao opened this issue May 18, 2018 · 3 comments

Comments

@cvarjao
Copy link
Member

cvarjao commented May 18, 2018

When the database pod is not yet available the mid lifecycle hook fails. We can avoid that by adding a pre lifecycle hook that will wait (Retry) until the database pod is up.
something along the lines of the existing Init Containers which protects the pod form startup if the database is not available, but it doesn't protect against the deployment.

Reference

@cvarjao cvarjao changed the title Missing pre lifecycle hook Missing 'pre' lifecycle hook May 18, 2018
@cvarjao
Copy link
Member Author

cvarjao commented May 30, 2018

Fixed on PR #714

@cvarjao cvarjao closed this as completed May 30, 2018
@garywong-bc
Copy link
Contributor

We should talk.. the mid-lifecycle hook ONLY serves to call post-deploy.sh which acts upon the (single) database. If we can put it in the Jenkins pipeline, for DEV/TEST and PROD then we no longer need this. We'll also separate out the DB_REPLICATE logic as this is no longer needed on DEV (fresh dataload everytime), nor on TEST (no overwriting of whatever is there), nor on PROD (replication will planned and co-ordinated).

I'm ready to do this anytime as it'll negate the need for a this task. @cvarjao @DerekRoberts

@DerekRoberts
Copy link
Member

@garywong-bc Good idea! I'd be happy to help.

@cvarjao Any opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants